Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the metric global package #2764

Merged
merged 4 commits into from Apr 5, 2022

Conversation

bradtopol
Copy link
Contributor

@bradtopol bradtopol commented Apr 4, 2022

Closes: #2752

Signed-off-by: Brad Topol btopol@us.ibm.com

Closes: 2752

Signed-off-by: Brad Topol <btopol@us.ibm.com>
@bradtopol
Copy link
Contributor Author

/cc @MrAlias

@bradtopol bradtopol changed the title This PR brings back the metric global package Bring back the metric global package Apr 4, 2022
Signed-off-by: Brad Topol <btopol@us.ibm.com>
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #2764 (4767581) into main (b7a5c1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2764   +/-   ##
=====================================
  Coverage   76.8%   76.8%           
=====================================
  Files        181     181           
  Lines      12189   12189           
=====================================
  Hits        9363    9363           
  Misses      2601    2601           
  Partials     225     225           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.0%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

Signed-off-by: Brad Topol <btopol@us.ibm.com>
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a few minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/example_test.go Outdated Show resolved Hide resolved
Signed-off-by: Brad Topol <btopol@us.ibm.com>
@MrAlias MrAlias merged commit c91da41 into open-telemetry:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address TODOs to bring back the metric global package
5 participants