Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back global metric Meter function #2750

Merged
merged 4 commits into from Mar 30, 2022
Merged

Add back global metric Meter function #2750

merged 4 commits into from Mar 30, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 29, 2022

This was removed in the API refactor. It is something that has been asked for.

@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited

Codecov Report

Merging #2750 (697a20c) into main (4385621) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2750     +/-   ##
=======================================
- Coverage   76.7%   76.7%   -0.1%     
=======================================
  Files        181     181             
  Lines      12174   12176      +2     
=======================================
- Hits        9348    9346      -2     
- Misses      2601    2605      +4     
  Partials     225     225
Impacted Files Coverage Δ
metric/global/global.go 0.0% <0.0%> (ø)
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.0%) ⬇️

@MrAlias MrAlias marked this pull request as ready for review March 29, 2022 23:49
@MrAlias MrAlias added this to the Release v1.7.0 milestone Mar 29, 2022
@MrAlias MrAlias mentioned this pull request Mar 30, 2022
Closed
13 tasks
XSAM
XSAM approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias merged commit ceead4a into open-telemetry:main Mar 30, 2022
@MrAlias MrAlias deleted the add-back-global-meter branch March 30, 2022 23:50
@MrAlias MrAlias modified the milestones: Release v1.6.2, Release v1.7.0 Apr 7, 2022
@Icarus9913 Icarus9913 mentioned this pull request Apr 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@XSAM XSAM XSAM approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
Release v1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrAlias @Aneurysm9 @MadVikingGod @XSAM