Document Resource options that potentially leak secrets #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WithProcess and WithProcessCommandArgs options contain command line arguments as resource attributes. These could potentially expose user secrets. Document this fact so users better understand the implications of using these options.
MrAlias
added
documentation
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2727 +/- ##
=====================================
Coverage 76.7% 76.7%
=====================================
Files 181 181
Lines 12175 12175
=====================================
+ Hits 9345 9347 +2
+ Misses 2605 2603 -2
Partials 225 225
|
plantfansam
approved these changes
Mar 25, 2022
XSAM
approved these changes
Mar 26, 2022
hickeyma
approved these changes
Mar 28, 2022
pellared
approved these changes
Mar 28, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WithProcessandWithProcessCommandArgsoptions contain command line arguments as resource attributes. These could potentially expose user secrets. Document this fact so users better understand the implications of using these options.Fix #2723