Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Link to the Go otel package #2726

Merged
merged 1 commit into from Mar 25, 2022
Merged

fix(doc): Link to the Go otel package #2726

merged 1 commit into from Mar 25, 2022

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Mar 25, 2022 •
edited

#964 moved the OpenTelemetry API to top level to go.opentelemetry.io/otel package. This PR fixes the outdated link in the README.

Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com

@MrAlias MrAlias added the documentation Provides helpful information label Mar 25, 2022
@MrAlias MrAlias added this to the Release v1.7.0 milestone Mar 25, 2022
@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 25, 2022
XSAM
XSAM approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hickeyma
Fix link to the Go otel package
c12ce99 
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2726 (c12ce99) into main (70a5446) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2726   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        181     181           
  Lines      12175   12175           
=====================================
+ Hits        9345    9347    +2     
+ Misses      2605    2603    -2     
  Partials     225     225
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias merged commit 0024f7c into open-telemetry:main Mar 25, 2022
@hickeyma hickeyma deleted the fix/go-otel-pkg-link branch March 28, 2022 07:14
@hickeyma
Copy link
Contributor Author

Thanks for the reviews folks and the merge.

@hickeyma hickeyma mentioned this pull request Apr 8, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plantfansam plantfansam plantfansam approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Release v1.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hickeyma @plantfansam @MrAlias @XSAM