Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fix from #2674 to all applicable lines #2719

Merged
merged 3 commits into from Mar 24, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 23, 2022

Continuation of #2674 and #2667. Adds same fix to other part of code that references the deprecated method.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2719 (b47174b) into main (4399e22) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2719   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        181     181           
  Lines      12175   12175           
=====================================
+ Hits        9345    9347    +2     
+ Misses      2605    2603    -2     
  Partials     225     225           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@plantfansam plantfansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit 70a5446 into open-telemetry:main Mar 24, 2022
@MrAlias MrAlias deleted the 2674-followup branch March 24, 2022 22:57
@MrAlias MrAlias added this to the Release v1.6.1 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants