silence tlsCert.RootCAs.Subjects is deprecated lint err

[sourikghosh]

Signed-off-by: Sourik Ghosh sourikghosh31@gmail.com

closes #2667

[sourikghosh]

any idea why EasyCLA workflow is not reporting ??

[MadVikingGod]

Thanks for taking this on. I didn't look into it too much because, as I said in the issue it affects 1.18. My guess was that this solution is fine especially because it's in tests.

There are two other places where Subjects() gets called, in exporters/otlp/otlpmetric/internal/otlpconfig/options_test.go and exporters/otlp/otlptrace/internal/otlpconfig/options_test.go. If we added the same nolint to those I think it would finish this.

If you want to test it install 1.18, and make sure that your golint isn't pointing to the default go version. I had to use GOROOT=~/sdk/go1.18beta2

For the EasyCLA, sometimes I've seen it mess up if you made the commit in the github web UI. If not it is a bug.

[MrAlias]

Please hold merging this until we release 1.5.0 #2676

[codecov]

Codecov Report

Merging #2674 (53876f4) into main (2cfc521) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #2674     +/-   ##
=======================================
- Coverage   75.8%   75.8%   -0.1%     
=======================================
  Files        173     173             
  Lines      11672   11672             
=======================================
- Hits        8854    8850      -4     
- Misses      2608    2612      +4     
  Partials     210     210             

Impacted Files	Coverage Δ
sdk/trace/batch_span_processor.go	80.2% <0.0%> (-1.9%)	⬇️