Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otel-collector example readme #2662

Merged
merged 2 commits into from Mar 10, 2022
Merged

Update otel-collector example readme #2662

merged 2 commits into from Mar 10, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Mar 8, 2022

Following this example I noticed a couple nits:

  • the kube-prometheus repo is now moved to prometheus-operator (link still works, just redirects... updating for clarity)
  • I couldn't get microk8s to work on my system, so using another local cluster I didn't realize I needed cert-manager. Lacking it produced this error when I ran make jaeger-operator-k8s:
unable to recognize "https://github.com/jaegertracing/jaeger-operator/releases/download/v1.31.0/jaeger-operator.yaml": no matches for kind "Certificate" in version "cert-manager.io/v1"
unable to recognize "https://github.com/jaegertracing/jaeger-operator/releases/download/v1.31.0/jaeger-operator.yaml": no matches for kind "Issuer" in version "cert-manager.io/v1"

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 8, 2022
@MrAlias MrAlias added documentation Provides helpful information pkg:example Related to an example labels Mar 10, 2022
@MrAlias MrAlias merged commit d3ab885 into open-telemetry:main Mar 10, 2022
@MrAlias MrAlias added this to the Release v1.5.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
documentation Provides helpful information pkg:example Related to an example Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Release v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@damemi @Aneurysm9 @dashpole @MrAlias @hanyuancheung