Double benchmark alert threshold #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Aneurysm9
approved these changes
Mar 3, 2022
dashpole
approved these changes
Mar 3, 2022
hanyuancheung
added
the
Skip Changelog
hanyuancheung
approved these changes
Mar 3, 2022
MrAlias
approved these changes
Mar 3, 2022
XSAM
approved these changes
Mar 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #2649 +/- ##
=======================================
- Coverage 75.8% 75.8% -0.1%
=======================================
Files 173 173
Lines 11664 11664
=======================================
- Hits 8846 8844 -2
- Misses 2608 2610 +2
Partials 210 210
|
hanyuancheung
added a commit
to hanyuancheung/opentelemetry-go
that referenced
this pull request
Mar 5, 2022
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the Action's doc about this config: https://github.com/benchmark-action/github-action-benchmark#alert-threshold-optional
We're getting benchmark failures on the main branch for a majority of commits. This would seem to be due to a lack of consistent performance in GH Actions (maybe noisy neighbours in co-located containers?).
From the failures I've looked at, it seems going to 400% should allow us to fix 90% of the current failures, though I doubt if the benchmark check will really still be so useful. We'll only really have the comment to rely on.