Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from opentracing Jaeger to opentelemetry #2642

Closed
dino-ma opened this issue Mar 1, 2022 · 8 comments
Closed

Migrating from opentracing Jaeger to opentelemetry #2642

dino-ma opened this issue Mar 1, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@dino-ma
Copy link

dino-ma commented Mar 1, 2022

I'd like to ask how to set probability sampling through opentelemetry. Previously, it was implemented through Jaeger's collector configuration by the client to request the interface of the agent. Now, opentelemetry will automatically implement this strategy. Don't we need to configure the service name and URL address?

And where can Jaeger's bufferflush interval be set?

@dino-ma dino-ma added the bug Something isn't working label Mar 1, 2022
@dino-ma
Copy link
Author

dino-ma commented Mar 1, 2022

jaegerConfig.ReporterConfig.BufferFlushInterval
jaegerConfig.SamplerConfig.SamplingServerURL

@dmathieu
Copy link
Member

dmathieu commented Mar 1, 2022

When using BatchSpanProcessor, you can specify a WithMaxQueueSize option which would be the rough equivalent of BufferFlushInterval.
The processor relies on the size of the queue instead of intervals. But the effect can be similar.

As for sampling, you can specify a sampler when creating the tracer provider. See this example: https://github.com/open-telemetry/opentelemetry-go/blob/main/example/namedtracer/main.go#L50
If your stack includes the collector, you may also do sampling at that level using the probabilistic sampler.

@dino-ma
Copy link
Author

dino-ma commented Mar 1, 2022

jaegerConfig.ReporterConfig.BufferFlushInterval

jaegerConfig. ReporterConfig. BufferFlushInterval

This is OK. I can accept it

However, I want to set the sampling rules through the remote collector instead of the default setting in the SDK.

@dmathieu
Copy link
Member

dmathieu commented Mar 1, 2022

You can do that with one of the included samplers (such as the probalistic one linked above) in opentelemetry-collector-contrib, or by writing your own.

@dino-ma
Copy link
Author

dino-ma commented Mar 2, 2022

In the future, do we plan to limit current through the remote like Jaeger

{ "service_strategies": [ { "service": "live", "type": "probabilistic", "param": 0.01, "operation_strategies": [ { "operation": "Kylin Rpc Server/v1/selfpage/brand", "type": "probabilistic", "param": 0.01 }, { "operation": "Kylin Rpc Server/v1/selfpage/feed", "type": "probabilistic", "param": 0.01 } ] }, { "service": "hoegaarden", "type": "probabilistic", "param": 0.1 } ], "default_strategy": { "type": "probabilistic", "param": 0.5, "operation_strategies": [ { "operation": "/metrics", "type": "probabilistic", "param": 0.0 }, { "operation": "Kylin Rpc Server/metrics", "type": "probabilistic", "param": 0.0 } ] } }

@dmathieu
Copy link
Member

dmathieu commented Mar 2, 2022

I think questions specific to the collector and its configuration would probably be better answered in the opentelemetry-collector repository.

@dino-ma
Copy link
Author

dino-ma commented Mar 2, 2022

Can this PR be merged?

@MrAlias
Copy link
Contributor

MrAlias commented Mar 18, 2022

Closing because open-telemetry/opentelemetry-go-contrib#936 has been merged. Please reopen if this was in error.

@MrAlias MrAlias closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants