Update span limits to comply with specification #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2637 +/- ##
=====================================
Coverage 75.6% 75.7%
=====================================
Files 172 172
Lines 11551 11619 +68
=====================================
+ Hits 8736 8798 +62
- Misses 2605 2611 +6
Partials 210 210
|
MrAlias
force-pushed
the
unlimited-limit-vals
branch
from
04e7ed4
to
d8eb930
Compare
MrAlias
force-pushed
the
unlimited-limit-vals
branch
from
7451a9a
to
8057d17
Compare
MrAlias
changed the title
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM and
dashpole
as code owners
MrAlias
requested review from
paivagustavo,
MadVikingGod and
pellared
as code owners
Update and unify documentation accordingly.
MrAlias
force-pushed
the
unlimited-limit-vals
branch
from
6c89ecb
to
c24c844
Compare
Aneurysm9
approved these changes
Feb 25, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hanyuancheung
approved these changes
Mar 3, 2022
hanyuancheung
pushed a commit
to hanyuancheung/opentelemetry-go
that referenced
this pull request
Mar 5, 2022
* PoC for span limit refactor * Rename config.go to span_limits.go * Add unit tests for truncateAttr * Add unit tests for non-string attrs * Add span limit benchmark tests * Fix lint * Isolate span limit tests * Clean span limits test * Test limits on exported spans * Remove duplicate test code * Fix lint * Add WithRawSpanLimits option * Add test for raw and orig span limits opts * Add changes to changelog * Add tests for span resource disabled * Test unlimited instead of default limit * Update docs * Add fix to changelog * Fix option docs * Do no mutate attribute * Fix truncateAttr comment * Remake NewSpanLimits to be newEnvSpanLimits Update and unify documentation accordingly. * Update truncateAttr string slice update comment * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2635
Fix #2636
OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMITOTEL_EVENT_ATTRIBUTE_COUNT_LIMITOTEL_LINK_ATTRIBUTE_COUNT_LIMITWithSpanLimitsin favor of the newWithRawSpanLimits.WithRawSpanLimitssupports0and unlimited limits.WithSpanLimitsis updated to preserve existing behavior.Testing