New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use port 4318 for otlp*http client default #2625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
February 17, 2022 17:21
Codecov Report
@@ Coverage Diff @@
## main #2625 +/- ##
=====================================
Coverage 76.1% 76.2%
=====================================
Files 173 173
Lines 12227 12249 +22
=====================================
+ Hits 9315 9337 +22
+ Misses 2669 2665 -4
- Partials 243 247 +4
|
Aneurysm9
approved these changes
Feb 21, 2022
XSAM
reviewed
Feb 22, 2022
XSAM
approved these changes
Feb 23, 2022
dmathieu
reviewed
Feb 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification and the collector defaults, use port
4318
as the default for HTTP communication.Fix #2614