Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use port 4318 for otlp*http client default #2625

Merged
merged 7 commits into from Feb 23, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 17, 2022

As per the specification and the collector defaults, use port 4318 as the default for HTTP communication.

Fix #2614

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #2625 (0affa8a) into main (94b1848) will increase coverage by 0.0%.
The diff coverage is 90.9%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2625   +/-   ##
=====================================
  Coverage   76.1%   76.2%           
=====================================
  Files        173     173           
  Lines      12227   12249   +22     
=====================================
+ Hits        9315    9337   +22     
+ Misses      2669    2665    -4     
- Partials     243     247    +4     
Impacted Files Coverage Δ
...ers/otlp/otlpmetric/internal/otlpconfig/options.go 80.2% <88.4%> (+4.2%) ⬆️
...ters/otlp/otlptrace/internal/otlpconfig/options.go 80.2% <88.4%> (+4.2%) ⬆️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.7% <100.0%> (-2.1%) ⬇️
...xporters/otlp/otlpmetric/otlpmetrichttp/options.go 72.9% <100.0%> (+2.3%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/client.go 81.7% <100.0%> (-1.6%) ⬇️
exporters/otlp/otlptrace/otlptracehttp/options.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 92.6% <0.0%> (-0.9%) ⬇️
... and 1 more

@MrAlias MrAlias merged commit 0a6e4d8 into open-telemetry:main Feb 23, 2022
@MrAlias MrAlias deleted the fix-2614 branch February 23, 2022 17:21
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collector and http client port mismatch
4 participants