Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the otlp trace exporter limit of SpanEvents when exporting #2616

Merged

Conversation

hanyuancheung
Copy link
Member

Fix #2607

Remove the limit of SpanEvents when exporting.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #2616 (8af4f24) into main (b675dda) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2616     +/-   ##
=======================================
- Coverage   76.2%   76.1%   -0.1%     
=======================================
  Files        173     173             
  Lines      12234   12234             
=======================================
- Hits        9324    9320      -4     
- Misses      2667    2671      +4     
  Partials     243     243             
Impacted Files Coverage Δ
sdk/internal/env/env.go 100.0% <ø> (ø)
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.5% <100.0%> (-0.2%) ⬇️
sdk/trace/config.go 100.0% <100.0%> (ø)
sdk/trace/provider.go 82.5% <100.0%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.9%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/internal/tracetransform/span.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/internal/tracetransform/span.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/internal/tracetransform/span.go Outdated Show resolved Hide resolved
hanyuancheung and others added 5 commits February 16, 2022 17:25
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@hanyuancheung hanyuancheung changed the title Remove the limit of SpanEvents when exporting Remove the otlp trace exporter limit of SpanEvents when exporting Feb 17, 2022
@MrAlias MrAlias merged commit 8297dbf into open-telemetry:main Feb 17, 2022
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP exporter limited to 128 SpanEvents
5 participants