Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector and http client port mismatch #2614

Closed
doggan opened this issue Feb 16, 2022 · 1 comment · Fixed by #2625
Closed

Collector and http client port mismatch #2614

doggan opened this issue Feb 16, 2022 · 1 comment · Fixed by #2625
Assignees
Labels
bug Something isn't working
Projects

Comments

@doggan
Copy link

doggan commented Feb 16, 2022

Description

otlptracehttp client defaults to port 4317, but collector spec says http uses 4318. (4317 is for grpc).

Environment

	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.4.0
	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.4.0
	go.opentelemetry.io/otel/sdk v1.4.0
	go.opentelemetry.io/otel/trace v1.4.0

Steps To Reproduce

  1. N/A

Expected behavior

I would expect the http client to default to port 4318, such that it is aligned with the port expected by the collector.

@doggan doggan added the bug Something isn't working label Feb 16, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Feb 16, 2022

The OpenTelemetry specification also states the port 4318 should be used as the default for HTTP.

This is currently unified in the internal/otlpconfig package.

It will need to be refactored to support different default values for the different clients.

@MrAlias MrAlias added this to Needs triage in Bugs via automation Feb 16, 2022
@MrAlias MrAlias moved this from Needs triage to High priority in Bugs Feb 16, 2022
@MrAlias MrAlias self-assigned this Feb 17, 2022
Bugs automation moved this from High priority to Closed Feb 23, 2022
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Bugs
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants