New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor development/CI tooling #2609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
- Coverage 76.2% 76.2% -0.1%
=======================================
Files 173 173
Lines 12238 12238
=======================================
- Hits 9328 9326 -2
- Misses 2667 2669 +2
Partials 243 243
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
February 14, 2022 21:17
Aneurysm9
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
pellared
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address in open-telemetry#2613 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALL_GO_MOD_DIRS
variable no longer filters out examples and then adds them back in.ALL_GO_MOD_DIRS
variable includes all Go module directories, including thetools
module.OTEL_GO_MOD_DIRS
is added to filter thetools
module out ofALL_GO_MOD_DIRS
.EXAMPLES
variable, it is no longer used (see below).build
target. The oldexamples
target is removed. It was always run on the CI system after thebuild
target anyway.test-default
, no longer outputs verbosely. Any relevant test failure will include a verbose output, but having it as the default creates human unreadable output.crosslink
and runninggo mod tidy
for modules is reversed. All modules are crosslinked before tidying to prevent "unknown module errors"golangci-lint
andgolangci-lint-fix
target are split fromlint
to run golangci-lint dirctly. Thegolangci-lint
target is split to be a dependency of theci
target, and thegolangci-lint-fix
target is a dependency ofprecommit
(see below on distinction). These can be run in parallel for jobs > 1.go-mod-tidy
target is split fromlint-modules
to rungo mod tidy
in every module directory. This can be run in parallel for jobs > 1.ci
no longer depends onprecommit
. Theci
target is trimmed down to only check things (instead of fixing things and failing without any useful information about what the actual changes to the files are). Theprecommit
target now will do it's best to fix any fixable issues it finds.Local Performance Overview
There are not comprehensive benchmarks, but show the general performance benifits of running locally with 8 jobs on an 8 core machine.
Which represents ~30% improvement for the experience runtime.