refactor: use Key's Defined method

[1046102779]

No description provided.

[codecov]

Codecov Report

Merging #2593 (eb8e591) into main (010ca4f) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #2593   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        173     173           
  Lines      12238   12238           
=====================================
  Hits        9326    9326           
  Misses      2669    2669           
  Partials     243     243           

Impacted Files	Coverage Δ
attribute/kv.go	50.0% <100.0%> (ø)
exporters/jaeger/jaeger.go	92.6% <0.0%> (-0.9%)	⬇️
sdk/trace/batch_span_processor.go	82.1% <0.0%> (+0.9%)	⬆️

[dmathieu]

You're marking this as an optimization (in your PR title). How is that so?
It seems the only reason for this change would be to reuse the key's validation, or for readability of the code.

[1046102779]

You're marking this as an optimization (in your PR title). How is that so? It seems the only reason for this change would be to reuse the key's validation, or for readability of the code.

Yes. Use existing method to maintain functional consistency.

Is it necessary for this change?

[pellared]

@1046102779 The title is misleading. I suggest changing to refactor: use Key's Defined method

PS. I think the change would rather decrease the performance than improve it 😄 for performance-related PRs you should include benchmarks

[1046102779]

@1046102779 The title is misleading. I suggest changing to refactor: use Key's Defined method

PS. I think the change would rather decrease the performance than improve it 😄 for performance-related PRs you should include benchmarks

ok , I run the benchmark for the change.