Add test units of histogram instrument kind

[Jacob953]

Done

• Add test units of histogram instrument kinds with "FloatmgMetricGroupingExport".

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Jacob953 (4fc52be)

[hanyuancheung]

Thanks for your contribution!

[Jacob953]

Thanks for your contribution!

It would be my pleasure! 🤗

[XSAM]

I am confused. The original comment of #2442 is to fix the end-to-end test of int64-histogram and float64-histogram, but I do not see such fix in this PR.

https://github.com/hanyuancheung/opentelemetry-go/blob/4d9d882c382641e5f11e72aa9ac9603281fb5a4b/exporters/otlp/otlpmetric/internal/otlpmetrictest/otlptest.go#L57-L58

[Jacob953]

I don't think now is the time to fix these two lines since it didn't support Summary Metrics well for now.

Intentionally trigger the assertion by making this line wrong to get objects of expected data back from exp.

[name:"test-int64-counter" sum:{data_points:{attributes:{key:"test" value:{bool_value:true}} start_time_unix_nano:1644882047272998000 time_unix_nano:1644882047273078000 as_int:1} aggregation_temporality:AGGREGATION_TEMPORALITY_CUMULATIVE is_monotonic:true}
name:"test-float64-counter" sum:{data_points:{attributes:{key:"test" value:{bool_value:true}} start_time_unix_nano:1644882047272998000 time_unix_nano:1644882047273078000 as_double:1} aggregation_temporality:AGGREGATION_TEMPORALITY_CUMULATIVE is_monotonic:true}
name:"test-int64-histogram" sum:{data_points:{attributes:{key:"test" value:{bool_value:true}} start_time_unix_nano:1644882047272998000 time_unix_nano:1644882047273078000 as_int:2} aggregation_temporality:AGGREGATION_TEMPORALITY_CUMULATIVE}
name:"test-float64-histogram" sum:{data_points:{attributes:{key:"test" value:{bool_value:true}} start_time_unix_nano:1644882047272998000 time_unix_nano:1644882047273078000 as_double:2} aggregation_temporality:AGGREGATION_TEMPORALITY_CUMULATIVE}
name:"test-int64-gaugeobserver" gauge:{data_points:{attributes:{key:"test" value:{bool_value:true}} time_unix_nano:1644882047273073000 as_int:3}}
name:"test-float64-gaugeobserver" gauge:{data_points:{attributes:{key:"test" value:{bool_value:true}} time_unix_nano:1644882047273074000 as_double:3}}]

The assertion obviously points that the object of Histogram is Sum which the same as Counter rather than Summary.

I think there is nothing wrong with this test code file by checking all relevant test files :)

[Jacob953]

And I'll try my best to take a part in #2280

[XSAM]

I accidentally deleted one of my comments. Here is the re-cap.

I think there is nothing wrong with this test code file by checking all relevant test files :)

Yeah, I think this PR is good. But it has nothing related to #2442. Would you like to delete the link with #2442?

[hanyuancheung]

I agree. Could you please open another pull request to resolve the ploblem above? @Jacob953

[codecov]

Codecov Report

Merging #2507 (7713723) into main (07ad32d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #2507   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        181     181           
  Lines      12175   12175           
=====================================
  Hits        9345    9345           
  Misses      2605    2605           
  Partials     225     225           

Impacted Files	Coverage Δ
sdk/trace/batch_span_processor.go	80.2% <0.0%> (-1.0%)	⬇️
exporters/jaeger/jaeger.go	91.1% <0.0%> (+0.8%)	⬆️

[Jacob953]

I agree. Could you please open another pull request to resolve the problem above? @Jacob953

I'll always pay attention to this problem. And could this PR be merged? :)