Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change UploadMetrics signature from slice to single Resource #2491

Merged

Conversation

hanyuancheung
Copy link
Member

@hanyuancheung hanyuancheung commented Jan 2, 2022

Fix: #2228

  • UploadMetrics() only ever receiving a single Resource, instead of taking []*metricpb.ResourceMetrics slice.
  • Change the code accordingly. Change its signature from slice to single one.

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #2491 (07344a0) into main (776bfdc) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2491     +/-   ##
=======================================
- Coverage   76.3%   76.3%   -0.1%     
=======================================
  Files        173     173             
  Lines      12022   12022             
=======================================
- Hits        9182    9179      -3     
- Misses      2597    2598      +1     
- Partials     243     245      +2     
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/exporter.go 60.6% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 97.7% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 78.7% <100.0%> (ø)
sdk/metric/refcount_mapped.go 80.0% <0.0%> (-20.0%) ⬇️
sdk/metric/sdk.go 80.0% <0.0%> (-1.5%) ⬇️
sdk/trace/batch_span_processor.go 85.4% <0.0%> (+2.0%) ⬆️

exporters/otlp/otlpmetric/exporter_test.go Outdated Show resolved Hide resolved
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 4b815ff into open-telemetry:main Jan 4, 2022
@MrAlias MrAlias mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP metrics exporter UploadMetrics signature change
4 participants