support zipkin exporter endpoint env #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Aneurysm9
requested changes
Jan 3, 2022
Aneurysm9
approved these changes
Jan 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #2490 +/- ##
=====================================
Coverage 76.3% 76.3%
=====================================
Files 173 174 +1
Lines 12022 12027 +5
=====================================
+ Hits 9177 9184 +7
+ Misses 2600 2598 -2
Partials 245 245
|
dashpole
approved these changes
Jan 4, 2022
added 3 commits
January 4, 2022 17:12
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
support-zipkin-env
branch
from
e03065e
to
ea9e3f6
Compare
|
Just fix the conflict on the changelog. Is it good to merge now? |
|
Please fix the lint issue, then this should be ready to merge. |
added 2 commits
January 4, 2022 19:25
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
XSAM
approved these changes
Jan 5, 2022
jcchavezs
reviewed
Jan 7, 2022
| @@ -79,7 +81,8 @@ func WithClient(client *http.Client) Option { | |||
| // New creates a new Zipkin exporter. | |||
| func New(collectorURL string, opts ...Option) (*Exporter, error) { | |||
| if collectorURL == "" { | |||
| return nil, errors.New("collector URL cannot be empty") | |||
| // Use endpoint from env var or default collector URL. | |||
| collectorURL = envOr(envEndpoint, defaultCollectorURL) | |||
There was a problem hiding this comment.
If we are overriding this, shall we add a info log explaining where this value comes from?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Fixes #2309.
This pr adds support of reading env
OTEL_EXPORTER_ZIPKIN_ENDPOINTto specify zipkin endpoint. If empty collector endpoint is provided, then the default collector address will be used mentioned in https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.1/specification/sdk-environment-variables.md#zipkin-exporter