Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-paste error for noop SDK AsyncInstrument #2376

Merged
merged 1 commit into from Nov 11, 2021

Conversation

evantorrie
Copy link
Contributor

As noted in #2370, the Noop SDK implementation of AsyncInstrument was returning the noopSyncInstrument.

This fixes the code to return the noopAsyncInstrument and also modifies the return type to AsyncImpl.

I marked this as Skip Changelog, but can add a Changelog entry if you consider it important enough.

@evantorrie evantorrie added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2376 (32efcaa) into main (249accd) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2376   +/-   ##
=====================================
  Coverage   73.8%   73.8%           
=====================================
  Files        175     175           
  Lines      12436   12436           
=====================================
+ Hits        9182    9189    +7     
+ Misses      3017    3012    -5     
+ Partials     237     235    -2     
Impacted Files Coverage Δ
metric/sdkapi/noop.go 61.5% <100.0%> (ø)
sdk/metric/sdk.go 81.6% <0.0%> (+1.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

@Aneurysm9 Aneurysm9 merged commit 3b9e067 into open-telemetry:main Nov 11, 2021
@MrAlias MrAlias mentioned this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants