Fix golint issue #2370
Merged
Fix golint issue #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hu Shuai <hus.fnst@fujitsu.com>
hs0210
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2370 +/- ##
=====================================
Coverage 73.8% 73.8%
=====================================
Files 175 175
Lines 12436 12436
=====================================
+ Hits 9178 9185 +7
+ Misses 3021 3015 -6
+ Partials 237 236 -1
|
|
Hi, I noticed that the return value of |
MadVikingGod
added
the
Skip Changelog
MadVikingGod
approved these changes
Nov 11, 2021
Aneurysm9
approved these changes
Nov 11, 2021
@jmacd might know. That does seem suspect though. |
MrAlias
approved these changes
Nov 11, 2021
MrAlias
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hu Shuai hus.fnst@fujitsu.com