Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Porto to dependancy list. #2369

Merged
merged 1 commit into from Nov 9, 2021
Merged

Add Porto to dependancy list. #2369

merged 1 commit into from Nov 9, 2021

Conversation

MadVikingGod
Copy link
Contributor

It was identified that the make precommit is broken on go 1.17. The generate step fails with:

go generate ./...
/bin/sh: 5: /workspaces/opentelemetry-go/.tools/porto: not found

This change adds porto to the dependency of the generate step, as it is used within this command.

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 8, 2021
@MrAlias MrAlias added the bug Something isn't working label Nov 9, 2021
@MrAlias MrAlias merged commit 05c4f10 into main Nov 9, 2021
@MrAlias MrAlias deleted the fix-precommit branch November 9, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants