Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor grammatical fix #2347

Merged
merged 3 commits into from Nov 10, 2021
Merged

Minor grammatical fix #2347

merged 3 commits into from Nov 10, 2021

Conversation

josephwoodward
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@pellared
Copy link
Member

pellared commented Nov 5, 2021

Are you able to sign the CLA?
More: https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md#sign-the-cla

@pellared pellared added blocked:CLA Waiting on CLA to be signed before progress can be made Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 5, 2021
@josephwoodward josephwoodward marked this pull request as ready for review November 6, 2021 05:17
@josephwoodward
Copy link
Contributor Author

@pellared Done 👍

@pellared pellared removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021 •
edited

Codecov Report

Merging #2347 (8ecb304) into main (43c55c3) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2347     +/-   ##
=======================================
- Coverage   73.8%   73.8%   -0.1%     
=======================================
  Files        175     175             
  Lines      12436   12436             
=======================================
- Hits        9185    9181      -4     
- Misses      3015    3019      +4     
  Partials     236     236
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 83.2% <0.0%> (-2.1%) ⬇️

@MrAlias MrAlias added the documentation Provides helpful information label Nov 10, 2021
@MrAlias MrAlias merged commit d0e5dd5 into open-telemetry:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@jmacd jmacd Awaiting requested review from jmacd

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephwoodward @pellared @dashpole @MrAlias @XSAM