Update the website getting started docs #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new example, fib, that contains an application for the computation of Fibonacci numbers. Use this example to update the website getting started documentation.
MrAlias
force-pushed
the
getting-started-docs
branch
from
c3949b2
to
cd084b8
Compare
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo,
pellared and
XSAM
as code owners
dashpole
reviewed
Aug 27, 2021
Aneurysm9
reviewed
Aug 27, 2021
MrAlias
force-pushed
the
getting-started-docs
branch
2 times, most recently
from
57e6b1c
to
8f2ee31
Compare
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
MrAlias
force-pushed
the
getting-started-docs
branch
from
8f2ee31
to
1a71cc5
Compare
Aneurysm9
reviewed
Aug 27, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Aneurysm9
approved these changes
Aug 27, 2021
jmacd
approved these changes
Aug 31, 2021
evantorrie
reviewed
Sep 1, 2021
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #2203 +/- ##
=====================================
Coverage 72.8% 72.9%
=====================================
Files 176 176
Lines 12162 12162
=====================================
+ Hits 8866 8868 +2
+ Misses 3057 3055 -2
Partials 239 239
|
seh
reviewed
Sep 2, 2021
Comment on lines
+83
to
+84
| sigCh := make(chan os.Signal, 1) | ||
| signal.Notify(sigCh, os.Interrupt) |
There was a problem hiding this comment.
Consider using the signal.NotifyContext function instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new example, fib, that contains an application for the computation of Fibonacci numbers. Use this example to update the website getting started documentation.
Resolves #2117