Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove WithTrace* options from otlptrace exporters #1997

Merged
merged 5 commits into from Jun 11, 2021
Merged

remove WithTrace* options from otlptrace exporters #1997

merged 5 commits into from Jun 11, 2021

Conversation

paivagustavo
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1997 (d7df26d) into main (b33edaa) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1997     +/-   ##
=======================================
- Coverage   72.1%   72.1%   -0.1%     
=======================================
  Files        159     159             
  Lines       7954    7923     -31     
=======================================
- Hits        5742    5719     -23     
+ Misses      1983    1975      -8     
  Partials     229     229             
Impacted Files Coverage Δ
...ters/otlp/otlptrace/internal/otlpconfig/options.go 66.1% <ø> (-9.6%) ⬇️
exporters/otlp/otlptrace/otlptracegrpc/options.go 79.1% <ø> (+19.7%) ⬆️
...rs/otlp/otlptrace/internal/otlpconfig/envconfig.go 85.7% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/options.go 100.0% <100.0%> (ø)

@paivagustavo paivagustavo marked this pull request as ready for review June 11, 2021 20:26
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 11, 2021
@Aneurysm9 Aneurysm9 merged commit 377f7ce into open-telemetry:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants