Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schema support #1948

Closed
tigrannajaryan opened this issue May 25, 2021 · 4 comments
Closed

Add Schema support #1948

tigrannajaryan opened this issue May 25, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tigrannajaryan
Copy link
Member

Problem Statement

The specification recently added the concept of Schema. We need to add a corresponding implementation in the API and SDK.

Proposed Solution

Here is the proposal in the form of draft PRs:

@tigrannajaryan tigrannajaryan added the enhancement New feature or request label May 25, 2021
@tigrannajaryan
Copy link
Member Author

@Aneurysm9 @MrAlias I have 3 draft PRs that show the extent of necessary changes. How do you prefer to move forward? Should I now polish each individual PR and merge each as it is ready or you prefer all 3 to be fully cooked and only after that merge all 3 at once?

@tigrannajaryan tigrannajaryan self-assigned this May 27, 2021
@Aneurysm9
Copy link
Member

I think the draft PRs are already pretty close to mergeable, so polishing them individually would be fine by me.

@MrAlias
Copy link
Contributor

MrAlias commented May 27, 2021

I think the draft PRs are already pretty close to mergeable, so polishing them individually would be fine by me.

Agreed!

I'm okay with merging them separately. We will be sure to hold off releasing until they are all merged.

@MadVikingGod
Copy link
Contributor

With all of these merged can we close this? @Aneurysm9 @MrAlias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants