Add support for scheme in OTEL_EXPORTER_OTLP_ENDPOINT #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #1886 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 139 139
Lines 7425 7449 +24
=====================================
+ Hits 5896 5918 +22
+ Misses 1285 1283 -2
- Partials 244 248 +4
|
Aneurysm9
approved these changes
May 10, 2021
XSAM
approved these changes
May 11, 2021
pellared
reviewed
May 11, 2021
| @@ -71,13 +71,13 @@ func (e *EnvOptionsReader) GetOptionsFromEnv() []GenericOption { | |||
|
|
|||
| // Endpoint | |||
| if v, ok := e.getEnvValue("ENDPOINT"); ok { | |||
| opts = append(opts, WithEndpoint(v)) | |||
| opts = append(opts, endpointOptions(v, WithEndpoint, withInsecure)...) | |||
There was a problem hiding this comment.
Could this be simplified, and clarified by doing something like:
opts = append(opts,
WithEndpoint(trimSchema(v)),
withInsecure(strings.HasPrefix(v, "http://")),
)
There was a problem hiding this comment.
I changed it towards this direction, but with an explicit WithSecure function which makes it a little bit more verbose
pellared
reviewed
May 12, 2021
pellared
reviewed
May 12, 2021
pellared
reviewed
May 12, 2021
pellared
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the environment variable configuration to accept the OTLP Exporter Endpoint environment variables according to the spec. This includes the following changes:
http-> insecure,https-> secure)Resolves #1885