Fix default merging of resource attributes from environment variable #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment vairable and WithResource() configuration for TracerProvider and Controller
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
dhruv-vora
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1785 +/- ##
=====================================
Coverage 78.4% 78.4%
=====================================
Files 135 135
Lines 7247 7252 +5
=====================================
+ Hits 5685 5689 +4
- Misses 1315 1316 +1
Partials 247 247
|
Aneurysm9
approved these changes
Apr 15, 2021
MrAlias
approved these changes
Apr 20, 2021
MrAlias
reviewed
Apr 20, 2021
|
This looks ready to merge. @dhruv-vora can you sync with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the resource attributes from the
OTEL_RESOURCE_ATTRIBUTESenvironment variable and merged them with theresource.Defaultresource as well as resources provided to theTracerProviderand metricController.Fixes #1689