Add test to check bsp ignores OnEnd and ForceFlush post Shutdown`
#1772
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynthiakedu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1772 +/- ##
=====================================
Coverage 78.7% 78.8%
=====================================
Files 134 134
Lines 7144 7144
=====================================
+ Hits 5626 5630 +4
+ Misses 1272 1268 -4
Partials 246 246
|
MrAlias
reviewed
Apr 5, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
cynthiakedu
force-pushed
the
checkBspPostShutdown
branch
from
d96b2b4 to
7bdb697
Compare
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
cynthiakedu
force-pushed
the
checkBspPostShutdown
branch
from
7bdb697 to
b030d4d
Compare
MrAlias
approved these changes
Apr 5, 2021
Aneurysm9
approved these changes
Apr 6, 2021
6 tasks
This was referenced Apr 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for #1617.
In #1746, discussed and decided to not add any additional short circuit to ignore
OnEndandForceFlushpostShutdown-- these methods are already ignored. Instead, adding a test to check that this behavior is enforced and will be in the future.