Make TraceFlags spec-compliant #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
* Remove `trace.FlagsDebug` and `trace.FlagsDeferred` * These are used only by the B3 propagator and will be handled there in the `context.Context` * Make `trace.TraceFlags` a defined type, aliasing `byte` * Move `IsSampled` method from `trace.SpanContext` to `trace.TraceFlags` * Add `Sampled(bool)` method to `trace.TraceFlags` * Implement `Stringer` and `json.Marshaler` for `trace.TraceFlags` Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Aneurysm9
force-pushed
the
span_context_trace_flags
branch
from
cad7d2c
to
5ad4d1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1770 +/- ##
=====================================
Coverage 78.5% 78.6%
=====================================
Files 134 134
Lines 7126 7129 +3
=====================================
+ Hits 5600 5605 +5
+ Misses 1277 1275 -2
Partials 249 249
|
MrAlias
reviewed
Apr 1, 2021
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
paivagustavo
approved these changes
Apr 2, 2021
…o span_context_trace_flags
XSAM
approved these changes
Apr 5, 2021
MrAlias
approved these changes
Apr 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace.FlagsDebugandtrace.FlagsDeferredcontext.Contexttrace.TraceFlagsa defined type, aliasingbyteIsSampledmethod fromtrace.SpanContexttotrace.TraceFlagsSampled(bool)method totrace.TraceFlagsStringerandjson.Marshalerfortrace.TraceFlagsFixes #1515. Closes #1516.