Rename WithDefaultSampler TracerProvider option to WithSampler and update docs #1702
+62
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term "DefaultSampler" comes from early ideas of this project where there would be overriding samplers lower in the trace SDK. This overriding does not exist and if it is going to be introduced in the future the sampler associated with the TracerProvider is already scoped based on that association (no need to scope with a name). This renames the TracerProvider option to not include this anachronism.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
|
If one does not pass the |
|
@seh opentelemetry-go/sdk/trace/provider.go Line 69 in 345f264 |
|
Thanks for the reference. What do you think about mentioning that in the documentation for |
SGTM |
seh
reviewed
Mar 16, 2021
Co-authored-by: Steven E. Harris <seh@panix.com>
MrAlias
changed the title
seh
approved these changes
Mar 16, 2021
XSAM
approved these changes
Mar 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #1702 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 130 130
Lines 7013 7013
=====================================
+ Hits 5461 5463 +2
+ Misses 1301 1299 -2
Partials 251 251
|
Aneurysm9
approved these changes
Mar 18, 2021
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term "DefaultSampler" comes from early ideas of this project where there would be overriding samplers lower in the trace SDK. This overriding does not exist and if it is going to be introduced in the future the sampler associated with the TracerProvider is already scoped based on that association (no need to scope with a name). This renames the TracerProvider option to not include this anachronism.
This does not rename the
TracerProviderconfig which is being removed in #1693