Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tracestate in TraceContext propagator #1447

Merged
merged 4 commits into from Jan 12, 2021
Merged

Handle tracestate in TraceContext propagator #1447

merged 4 commits into from Jan 12, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #1394.

@Aneurysm9
TraceContext propagator now handles tracestate.
07a6542 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited

Codecov Report

Merging #1447 (c184042) into master (49f699d) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1447   +/-   ##
======================================
  Coverage    78.8%   78.8%           
======================================
  Files         130     130           
  Lines        6642    6647    +5     
======================================
+ Hits         5239    5244    +5     
  Misses       1148    1148           
  Partials      255     255
Impacted Files Coverage Δ
propagation/trace_context.go 68.2% <100.0%> (+2.7%) ⬆️

@Aneurysm9 Aneurysm9 added area:propagators Part of OpenTelemetry context propagation pkg:API Related to an API package labels Jan 12, 2021
XSAM
XSAM reviewed Jan 12, 2021
View reviewed changes
propagation/trace_context.go Outdated Show resolved Hide resolved
@Aneurysm9
Prevent invalid tracestate from invalidating traceparent.
8e6b1f9 
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
XSAM
XSAM approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

MrAlias
MrAlias approved these changes Jan 12, 2021
View reviewed changes
propagation/trace_context_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 74deedd into open-telemetry:master Jan 12, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
area:propagators Part of OpenTelemetry context propagation pkg:API Related to an API package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagation: Use TraceState from SpanContext
4 participants
@Aneurysm9 @dashpole @MrAlias @XSAM