Histogram aggregator functional options #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
======================================
Coverage 78.9% 79.0%
======================================
Files 128 128
Lines 6672 6685 +13
======================================
+ Hits 5269 5282 +13
Misses 1148 1148
Partials 255 255
|
|
@bogdandrutu Please review. |
bogdandrutu
reviewed
Jan 6, 2021
Aneurysm9
approved these changes
Jan 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a functional option
WithExplicitBoundaries()where there was formerly an explicit[]float64argument.This is to prepare for open-telemetry/opentelemetry-specification#982, adding multiple histogram boundary schemes.
This uses the Prometheus default histogram buckets (11) as the default for floating point histograms (0.005 ... 10). Integer histograms use the same bucket defaults multiplied by 1e6 (5_000 ... 10_000_000).