Adding Security Workflows to GitHub Actions (2/2): gosec workflow #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
approved these changes
Jan 3, 2021
XSAM
approved these changes
Jan 3, 2021
MrAlias
approved these changes
Jan 6, 2021
|
@AzfaarQureshi guessing you're on this, but if you could updated to the latest this looks ready to merge next. |
|
@MrAlias yup, rebased! |
AzfaarQureshi
force-pushed
the
gosec-gha
branch
from
45da690
to
1ead36a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
========================================
- Coverage 78.6% 78.6% -0.1%
========================================
Files 126 126
Lines 6375 6375
========================================
- Hits 5017 5015 -2
- Misses 1114 1115 +1
- Partials 244 245 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #1429 and issue open-telemetry/oteps#144
Gosec is a static analysis engine which scans go source code for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.
Changes
Workflow Triggers
cc- @alolita