Move gRPC driver to a subpackage and add an HTTP driver #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
krnowak
force-pushed
the
otlp-exporter-5
branch
from
6d4d41d
to
5ea0611
Compare
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
========================================
+ Coverage 78.6% 78.8% +0.1%
========================================
Files 126 131 +5
Lines 6375 6753 +378
========================================
+ Hits 5017 5326 +309
- Misses 1114 1167 +53
- Partials 244 260 +16
|
punya
reviewed
Dec 28, 2020
| fallthrough | ||
| case http.StatusServiceUnavailable: | ||
| select { | ||
| case <-time.After(getWaitDuration(d.cfg.backoff, i)): |
There was a problem hiding this comment.
Should this respect the Retry-After header in addition to performing exponential backoff?
There was a problem hiding this comment.
Yeah, it should, but I decided to punt that to some follow-up PR.
Aneurysm9
reviewed
Jan 3, 2021
krnowak
force-pushed
the
otlp-exporter-5
branch
from
5ea0611
to
5349a01
Compare
jmacd
approved these changes
Jan 6, 2021
krnowak
force-pushed
the
otlp-exporter-5
branch
from
6bab96b
to
5f5f949
Compare
Aneurysm9
approved these changes
Jan 6, 2021
dashpole
approved these changes
Jan 7, 2021
punya
approved these changes
Jan 7, 2021
XSAM
approved these changes
Jan 8, 2021
This is what the specification says for both gRPC and HTTP.
Currently it supports only binary protobuf payloads.
It also adds some common code mock collectors can use. This will be useful for testing the HTTP driver.
It also extends the one record checkpointer a bit. This will be useful for testing the HTTP driver.
We create our own instance of the transport, which is based on golang's DefaultTransport. That way we sidestep the issue of the DefaultTransport being modified/overwritten. We won't have any panics at init. The cost of it is to keep the transport fields in sync with DefaultTransport.
This may help with connection reuse.
krnowak
force-pushed
the
otlp-exporter-5
branch
from
5f5f949
to
93e8c25
Compare
|
Updated. Rebased to current master and fixed conflicts in changelog. |
krnowak
force-pushed
the
otlp-exporter-5
branch
from
93e8c25
to
9f96b91
Compare
This was referenced Jan 12, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be quite large, because I moved a bunch of code from one place to another. So maybe reviewing this PR will be more manageable if done commit-by-commit. If it's still too large then I suppose I can split the PR into three smaller ones like:
Please let me know.
Anyway, the new HTTP driver supports only binary protobuf payloads. The support for JSON format would be a follow-up PR to this one.