From 249accddba5eaa93754a17846299fe224254ae2e Mon Sep 17 00:00:00 2001 From: Hu Shuai Date: Fri, 12 Nov 2021 00:49:28 +0800 Subject: [PATCH 1/2] Fix golint issue (#2370) Signed-off-by: Hu Shuai --- metric/sdkapi/noop.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metric/sdkapi/noop.go b/metric/sdkapi/noop.go index c5bf5452f02..90450d3968d 100644 --- a/metric/sdkapi/noop.go +++ b/metric/sdkapi/noop.go @@ -36,7 +36,7 @@ func NewNoopSyncInstrument() SyncImpl { return noopSyncInstrument{} } -// NewNoopSyncInstrument returns a No-op implementation of the +// NewNoopAsyncInstrument returns a No-op implementation of the // asynchronous instrument interface. func NewNoopAsyncInstrument() SyncImpl { return noopSyncInstrument{} From 3b9e067483c9341f6f48b2d028a89b00a2a50a5f Mon Sep 17 00:00:00 2001 From: ET Date: Thu, 11 Nov 2021 14:21:12 -0800 Subject: [PATCH 2/2] Fix copy-paste error for noop SDK AsyncInstrument (#2376) --- metric/sdkapi/noop.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/metric/sdkapi/noop.go b/metric/sdkapi/noop.go index 90450d3968d..0aca8523ddf 100644 --- a/metric/sdkapi/noop.go +++ b/metric/sdkapi/noop.go @@ -38,8 +38,8 @@ func NewNoopSyncInstrument() SyncImpl { // NewNoopAsyncInstrument returns a No-op implementation of the // asynchronous instrument interface. -func NewNoopAsyncInstrument() SyncImpl { - return noopSyncInstrument{} +func NewNoopAsyncInstrument() AsyncImpl { + return noopAsyncInstrument{} } func (noopInstrument) Implementation() interface{} {