From 3c8477078e0ec8ad47ae2c78d1dc89726ed723cc Mon Sep 17 00:00:00 2001 From: Ziqi Zhao Date: Fri, 25 Nov 2022 13:36:04 +0800 Subject: [PATCH] fix for review Signed-off-by: Ziqi Zhao --- exporters/prometheus/exporter.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/exporters/prometheus/exporter.go b/exporters/prometheus/exporter.go index 8cc87573db9..41fa546d73a 100644 --- a/exporters/prometheus/exporter.go +++ b/exporters/prometheus/exporter.go @@ -392,17 +392,14 @@ func validateMetrics(name, description string, metricType *dto.MetricType, mfs m } return false, "" } - if emf.GetHelp() != description { if emf.GetType() == dto.MetricType_HISTOGRAM || *metricType == dto.MetricType_HISTOGRAM { return false, "" } return false, emf.GetHelp() } - if emf.GetType() != *metricType { return true, "" } - return false, "" }