Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Add SpanStartOptions behavior to stats_handlers #5431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

otelgrpc: Add SpanStartOptions behavior to stats_handlers #5431

wants to merge 2 commits into from

Conversation

josepedropereira
Copy link

Closes #5430

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 26, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

pellared
pellared requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking per #5251 (review)

I plan to bring this topic to the next SIG meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared requested changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

otelgrpc: add WithSpanOptions behavior to stats_handler
2 participants
@josepedropereira @pellared