Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: add WithSpanOptions behavior to stats_handler #5430

Open
josepedropereira opened this issue Apr 25, 2024 · 0 comments · May be fixed by #5431
Open

otelgrpc: add WithSpanOptions behavior to stats_handler #5430

josepedropereira opened this issue Apr 25, 2024 · 0 comments · May be fixed by #5431
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc

Comments

@josepedropereira
Copy link

Problem Statement

otelgrpc stats_handler does not support the config SpanStartOptions, even tho this config is supported in the deprecated interceptors since #3768

Proposed Solution

Append SpanStartOptions to the stats_handler SpanStartOptions like it's done on the interceptors side to have the same functionality for both use cases.
@josepedropereira josepedropereira added area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc labels Apr 25, 2024
@josepedropereira josepedropereira linked a pull request Apr 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

otelgrpc: Add SpanStartOptions behavior to stats_handlers josepedropereira/opentelemetry-go-contrib
1 participant
@josepedropereira