Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a resource detector for Azure VMs #5422

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add a resource detector for Azure VMs #5422

wants to merge 7 commits into from

Conversation

pyohannes
Copy link

Fixes #5421

This PR adds a resource detector for Azure VMs which sets values according to to semantic conventions for host, cloud, and os resources:

  • cloud.provider
  • cloud.platform
  • host.id
  • host.name
  • host.type
  • os.type
  • os.version

@pyohannes pyohannes requested a review from a team as a code owner April 23, 2024 12:29
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited

Codecov Report

Attention: Patch coverage is 78.18182% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 62.4%. Comparing base (fed6e67) to head (6929fd0).

❗ Current head 6929fd0 differs from pull request most recent head 33122e5. Consider uploading reports for the commit 33122e5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5422   +/-   ##
=====================================
  Coverage   62.3%   62.4%           
=====================================
  Files        189     190    +1     
  Lines      11575   11630   +55     
=====================================
+ Hits        7219    7262   +43     
- Misses      4146    4158   +12     
  Partials     210     210
Files Coverage Δ
detectors/azure/vm/vm.go 78.1% <78.1%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a resource detector for Azure VMs
1 participant
@pyohannes