Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for new component: Baggage Span Processor #5397

Closed
codeboten opened this issue Apr 15, 2024 · 0 comments · Fixed by #5404
Closed

Request for new component: Baggage Span Processor #5397

codeboten opened this issue Apr 15, 2024 · 0 comments · Fixed by #5404

Comments

@codeboten
Copy link
Contributor

The Honeycomb distro currently provides a Span processor that takes items from the baggage and adds those items as attributes onto spans. We'd like to donate this code upstream if there's an interest from the community, the code is pretty minimal: https://github.com/honeycombio/honeycomb-opentelemetry-go/blob/main/baggage_span_processor.go
codeboten added a commit to codeboten/opentelemetry-go-contrib that referenced this issue Apr 18, 2024
@codeboten
processors/baggage: add baggage span processor
9f17aed 
Fixes open-telemetry#5397

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten mentioned this issue Apr 18, 2024
Merged
MrAlias pushed a commit that referenced this issue May 6, 2024
@codeboten @pellared
@dmathieu @MikeGoldsmith @MadVikingGod
processors/baggage: add baggage span processor (#5404)
31c8398 
* processors/baggage: add baggage span processor

Fixes #5397

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* fix lint issues + dependabot generate

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* apply review feedback

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* more review feedback

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* Update processors/baggage/processor_test.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* lint

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* feedback from review

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* rename baggage -> baggagetrace

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* more fixes

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* docs

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* lint fixes

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* generate

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Damien Mathieu <42@dmathieu.com>

* Update CHANGELOG.md

* Update processors/baggage/baggagetrace/doc.go

* Apply suggestions from code review

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update processors/baggage/baggagetrace/processor.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Apply suggestions from code review

* Update CHANGELOG.md

* Update CODEOWNERS

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this issue May 7, 2024
@codeboten @pellared
@dmathieu @MikeGoldsmith @MadVikingGod @zailic
processors/baggage: add baggage span processor (open-telemetry#5404)
726a0bf 
* processors/baggage: add baggage span processor

Fixes open-telemetry#5397

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* fix lint issues + dependabot generate

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* apply review feedback

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* more review feedback

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* Update processors/baggage/processor_test.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* lint

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* feedback from review

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* rename baggage -> baggagetrace

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* more fixes

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* docs

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* lint fixes

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* generate

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Damien Mathieu <42@dmathieu.com>

* Update CHANGELOG.md

* Update processors/baggage/baggagetrace/doc.go

* Apply suggestions from code review

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update processors/baggage/baggagetrace/processor.go

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Apply suggestions from code review

* Update CHANGELOG.md

* Update CODEOWNERS

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

processors/baggage: add baggage span processor codeboten/opentelemetry-go-contrib
1 participant
@codeboten