Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zap log bridge #5191

Open
pellared opened this issue Mar 1, 2024 · 3 comments
Open

Add zap log bridge #5191

pellared opened this issue Mar 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@pellared
Copy link
Member

pellared commented Mar 1, 2024

Add zapcore.Core log bridge.

@pellared
Copy link
Member Author

@khushijain21 is working on it.

@khushijain21
Copy link
Contributor

khushijain21 commented May 7, 2024

Outline of the approach

  • Skeleteon of zapcore and config for the bridge
  • Implement Enabled, Check method
  • Implement zapcore encoder
  • Implement With and Write method
  • Add Benchmarks

@pellared
Copy link
Member Author

pellared commented May 7, 2024

  1. We do not need to implement zapcore.Encoder as we are providing a zapcore.Core
  2. You can first implement Write and then With method as separate PRs
  3. You can handle https://pkg.go.dev/go.uber.org/zap/zapcore#NamespaceType as a separate PR
  4. You can handle trace correlation (handling context.Context) as a separate PR
  5. After benchmarks are in place we can add performance improvements. I suggests adding usage of sync.Pool and other improvements after benchmarks are in place and we have required functionality in place.
  6. Go doc comment should be updated after the implementation is done.
  7. A testable example should be added demonstrating how to setup otelzap.
  8. After the release the Go module should be added to https://opentelemetry.io/ecosystem/registry
  9. After the release we could document the bridge also in https://opentelemetry.io/docs/languages/go/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

2 participants