Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgro #4315

Closed
pellared opened this issue Sep 18, 2023 · 1 comment
Closed

otelgro #4315

pellared opened this issue Sep 18, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@pellared
Copy link
Member

I noticed that the stats handler misses the functionality you added here: #2700. Any reasons for that?

I was plan to implement the stats.handler step by step, cover the trace first, and then cover the metrics. Which is also convenient for review.
Do you think I should implement it in this pr or create another pr for metrics?
I'm open for both way. @pellared

During the SIG meetings we discussed that we would like to have a feature-parity before we deprecate interceptors as part of #3002 (review).

Still I think we can tackle it in a separate PR.

Are there any other features which are missing when comparing with the interceptors?

I think metric is the only missing feature, since I wrote a simple e2e test TestStatsHandler just like interceptors to make sure the trace related function is complete.
@pellared

Originally posted by @fatsheep9146 in #3002 (comment)

@pellared
Copy link
Member Author

Duplicates #4316

@pellared pellared added the duplicate This issue or pull request already exists label Sep 18, 2023
@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant