Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for Go 1.20 #3372

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Add testing for Go 1.20 #3372

merged 9 commits into from
Feb 13, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 7, 2023

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #3372 (f9441ec) into main (6178903) will increase coverage by 0.0%.
The diff coverage is 80.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3372   +/-   ##
=====================================
  Coverage   69.5%   69.6%           
=====================================
  Files        147     147           
  Lines       6894    6910   +16     
=====================================
+ Hits        4796    4812   +16     
  Misses      1978    1978           
  Partials     120     120           
Impacted Files Coverage Δ
detectors/gcp/gce.go 8.7% <0.0%> (ø)
detectors/gcp/gke.go 0.0% <0.0%> (ø)
....mongodb.org/mongo-driver/mongo/otelmongo/mongo.go 0.0% <0.0%> (ø)
detectors/aws/ecs/ecs.go 18.0% <18.1%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.3% <50.0%> (ø)
instrumentation/net/http/otelhttp/handler.go 82.6% <50.0%> (ø)
detectors/aws/ec2/ec2.go 89.0% <100.0%> (ø)
detectors/aws/eks/detector.go 35.6% <100.0%> (ø)
detectors/aws/lambda/detector.go 92.8% <100.0%> (ø)
detectors/gcp/cloud-function.go 100.0% <100.0%> (ø)
... and 17 more

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 9, 2023

The beego instrumentation testing holds a handle to a temporary file on Windows systems. The testing system is therefore not able to cleanly close the file handle. This updates that test to use a mock filesystem instead.

@MrAlias MrAlias merged commit 25dc70f into open-telemetry:main Feb 13, 2023
@MrAlias MrAlias deleted the go-1.20 branch February 13, 2023 15:29
@MrAlias MrAlias added this to the v0.39.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants