Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semconv creation functions #3369

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 7, 2023

Follow up to open-telemetry/opentelemetry-go#3675

Fixed

  • The span name of producer spans from go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama is corrected to use publish instead of send.
  • Attribute types are corrected in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws.
    • aws.dynamodb.table_names is now a string slice value.
    • aws.dynamodb.global_secondary_indexes is now a string slice value.
    • aws.dynamodb.local_secondary_indexes is now a string slice value.
    • aws.dynamodb.attribute_definitions is now a string slice value.
    • aws.dynamodb.global_secondary_index_updates is now a string slice value.
    • aws.dynamodb.provisioned_read_capacity is now a float64 value.
    • aws.dynamodb.provisioned_write_capacity is now a float64 value.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3369 (a0d4132) into main (6178903) will increase coverage by 5.2%.
The diff coverage is 85.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3369     +/-   ##
=======================================
+ Coverage   69.5%   74.7%   +5.2%     
=======================================
  Files        147     152      +5     
  Lines       6894    6975     +81     
=======================================
+ Hits        4796    5217    +421     
+ Misses      1978    1622    -356     
- Partials     120     136     +16     
Impacted Files Coverage Δ
detectors/gcp/gce.go 8.7% <0.0%> (ø)
detectors/gcp/gke.go 0.0% <0.0%> (ø)
detectors/aws/ecs/ecs.go 18.0% <18.1%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.3% <50.0%> (ø)
instrumentation/net/http/otelhttp/handler.go 82.6% <50.0%> (ø)
detectors/aws/ec2/ec2.go 89.0% <100.0%> (ø)
detectors/aws/eks/detector.go 35.6% <100.0%> (ø)
detectors/aws/lambda/detector.go 92.8% <100.0%> (ø)
detectors/gcp/cloud-function.go 100.0% <100.0%> (ø)
detectors/gcp/cloud-run.go 100.0% <100.0%> (ø)
... and 34 more

@MrAlias MrAlias merged commit c52452d into open-telemetry:main Feb 8, 2023
@MrAlias MrAlias deleted the use-semconv-func branch February 8, 2023 17:37
@MrAlias MrAlias added this to the v0.39.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants