[runtime] Change runtime.uptime instrument from Int64ObservableUpDownCounter to Int64ObservableCounter
#3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
matej-g
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
=======================================
- Coverage 69.5% 69.4% -0.1%
=======================================
Files 147 147
Lines 6890 6890
=======================================
- Hits 4789 4786 -3
- Misses 1980 1982 +2
- Partials 121 122 +1
|
MrAlias
approved these changes
Jan 31, 2023
hanyuancheung
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera matej.gera@coralogix.com
runtime.uptimecaptures the uptime of the process, meaning it is monotonic - there doesn't seem to be reason for this to be up down counter instead of just a counter.