Add missing recommended resource attributes to AWS Lambda detector #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- faas.instance (corresponds to log stream name) - faas.max_memory Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
matej-g
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
=====================================
Coverage 69.2% 69.3%
=====================================
Files 147 147
Lines 6884 6893 +9
=====================================
+ Hits 4768 4777 +9
Misses 2000 2000
Partials 116 116
|
Aneurysm9
approved these changes
Jan 13, 2023
MrAlias
approved these changes
Jan 14, 2023
|
Please update this branch with |
hanyuancheung
approved these changes
Jan 16, 2023
…commended-attributes
|
@MrAlias done, thank you 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing resource attributes in accordance with the FaaS specification (https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/faas/), in particular
faas.instanceandfaas.max_memory.Adjusts relevant tests as well.