Improve documentation for samplers/jaegerremote by providing examples of sampling endpoints
#3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yurishkuro
commented
Jan 12, 2023
yurishkuro
commented
- Fix incorrect endpoint example
- Explain which servers can be used (cf Is Remote sampling works without Jaeger-agent sampling port 5778? jaegertracing/jaeger#4142)
…es of sampling endpoints Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
MrAlias
approved these changes
Jan 12, 2023
Aneurysm9
approved these changes
Jan 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
=======================================
- Coverage 69.2% 69.2% -0.1%
=======================================
Files 147 147
Lines 6884 6884
=======================================
- Hits 4768 4765 -3
- Misses 2000 2002 +2
- Partials 116 117 +1
|
hanyuancheung
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.