otelmux: Add new WithSpanNameFormatter option #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
from
8aed053
to
9e2f09a
Compare
dmathieu
reviewed
Nov 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
=====================================
Coverage 69.0% 69.0%
=====================================
Files 147 147
Lines 6875 6884 +9
=====================================
+ Hits 4745 4752 +7
- Misses 2011 2014 +3
+ Partials 119 118 -1
|
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
2 times, most recently
from
455babb
to
1fb06e0
Compare
dmathieu
reviewed
Nov 30, 2022
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
from
241e457
to
9899b15
Compare
|
I've rebased - can I get a re-review? |
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
from
9899b15
to
3d89e36
Compare
dmathieu
approved these changes
Dec 7, 2022
|
thanks for the approval @dmathieu 🙇♂️ |
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
from
3d89e36
to
3608476
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
otelmux-configurable-spanNameFormatter-3040
branch
from
3608476
to
08d3435
Compare
|
@dmathieu Any idea what's remaining to get this merged? |
MadVikingGod
approved these changes
Dec 15, 2022
hairyhenderson
deleted the
otelmux-configurable-spanNameFormatter-3040
branch
|
Thanks @MadVikingGod 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3040
Signed-off-by: Dave Henderson dhenderson@gmail.com