Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filters to the otelgin package #2965

Merged
merged 5 commits into from Nov 9, 2022
Merged

Add support for filters to the otelgin package #2965

merged 5 commits into from Nov 9, 2022

Conversation

Orogenesis
Copy link
Contributor

@Orogenesis Orogenesis commented Nov 3, 2022 •
edited by MrAlias

Enhance otelgin to support filtering.

Fixes #2963.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Orogenesis / name: Maxim (502cba4)

@Orogenesis Orogenesis changed the title Add support for filters to the otelgin package #2963 Add support for filters to the otelgin package Nov 3, 2022
MrAlias
MrAlias reviewed Nov 3, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation/github.com/gin-gonic/gin/otelgin/option.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited

Codecov Report

Merging #2965 (7d804ad) into main (44d8196) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2965   +/-   ##
=====================================
  Coverage   69.6%   69.7%           
=====================================
  Files        147     147           
  Lines       6795    6806   +11     
=====================================
+ Hits        4732    4746   +14     
+ Misses      1946    1944    -2     
+ Partials     117     116    -1
Impacted Files Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 82.3% <100.0%> (+1.5%) ⬆️
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.9% <0.0%> (+0.9%) ⬆️

MrAlias
MrAlias reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to sync with main

CHANGELOG.md Show resolved Hide resolved
Orogenesis and others added 2 commits November 3, 2022 19:27
@Orogenesis @MrAlias
Update CHANGELOG.md
ee6a946 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@Orogenesis
Merge branch 'main' into otelgin-filter
2f3170b
@Orogenesis
Copy link
Contributor Author

@MrAlias updated.

@MrAlias MrAlias merged commit 9a9abd4 into open-telemetry:main Nov 9, 2022
@MadVikingGod MadVikingGod mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM

@dashpole dashpole Awaiting requested review from dashpole

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
instrumentation: otelgin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance gin-gonic tracer to support filtering
3 participants
@Orogenesis @dmathieu @MrAlias