Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize otelgrpc, avoid unnecessary allocations and copies #2838

Merged
merged 1 commit into from Oct 7, 2022

Conversation

bogdandrutu
Copy link
Member

Depends on #2835

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #2838 (1d598cb) into main (1b75ca9) will decrease coverage by 0.1%.
The diff coverage is 84.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2838     +/-   ##
=======================================
- Coverage   69.4%   69.2%   -0.2%     
=======================================
  Files        145     145             
  Lines       6712    6709      -3     
=======================================
- Hits        4660    4648     -12     
- Misses      1938    1947      +9     
  Partials     114     114             
Impacted Files Coverage Δ
...ation/google.golang.org/grpc/otelgrpc/grpctrace.go 45.7% <78.9%> (-3.5%) ⬇️
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.4% <100.0%> (-0.8%) ⬇️

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@Aneurysm9 Aneurysm9 merged commit 773172b into open-telemetry:main Oct 7, 2022
@bogdandrutu bogdandrutu deleted the moreoptimization branch October 7, 2022 23:04
@MrAlias MrAlias mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants